Vue 3 Support #99
Vue 3 Support #99
Conversation
|
@fech-dev thank you so much for the PR and sorry for the delay in responding! After thinking about it some more, I think I am okay with completely dropping Vue 2 support, so if you would like to proceed with updating to entirely Vue 3 and composables, I support that 👍 |
Thanks @rwwagner90. Ok, I'll try to update asap. |
|
@fech-dev did you still want to update this PR? |
Sorry, for the late reply, but I was very busy. |
|
@fech-dev do you mind rebasing this please? |
Drop vue 2 support
Drop vue 2 support
RobbieTheWagner
force-pushed
the
feature/vue3-support
branch
from
baf6bc5 to
fe97f89
Compare
|
@fech-dev thanks for all the hard work! Just released 2.0.0 |
This PR adds the plugin's Vue 3 support + useShepherd() composable function for the usage in setup hooks.
To make that possible I use vue-demi library, but there are some limitations in terms of building the package.
In package.json's module field I have changed it to
src/entry.jsbecause vue-demi works at build time, so I remove the ESM compilation since it was unnecessary and user can directly usesrc/entry.js.The problem is for the SSR and unpkg versions... I think that the solution can be to build two versions of each build type, where:
One will still support Vue 2 (files named vue2-shepherd.min.js & vue2-shepherd.ssr.js)
and the others for Vue 3 (files named vue3-shepherd.min.js & vue3.shepherd.ssr.js).
These changes are not in this commit, if you are ok with this solution I'll make the change.